Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support connecting to SSL/TLS target socket #73

Closed
ghost opened this issue Aug 17, 2011 · 2 comments
Closed

Support connecting to SSL/TLS target socket #73

ghost opened this issue Aug 17, 2011 · 2 comments
Labels

Comments

@ghost
Copy link

ghost commented Aug 17, 2011

If I wrap a VNC server with stunnel, then I cannot use use it easily.

I can implement a new new_client, but the static method socket is not friendly.

Maybe we cannot a two optional parameters to socket: cert and key; or we can implement another sslsocket.

Should we consider it?

@kanaka
Copy link
Member

kanaka commented Aug 18, 2011

Just to make sure I understand, you want to add the ability to connect to a target SSL port? That sounds like a reasonable addition. I think adding optional cert/key parameters to the socket method would probably be best. There will also need to a new command line option such as --ssl-target since we won't be able to detect an ssl target like we can detect an ssl client.

If this is important to you, you can propose a change and I'll review it and pull it in once I approve of the changes. It might be a while before I am able to find time to work on that.

@kanaka
Copy link
Member

kanaka commented Aug 18, 2011

Oh, and can you file this under the websockify project instead? A keep a copy of websockify in noVNC for convenience but I maintain them as separate projects. I am going to close the bug on this end. Thanks.

@kanaka kanaka closed this as completed Aug 18, 2011
sleongmgi pushed a commit to sleongmgi/noVNC that referenced this issue Jan 23, 2020
* refactor vnc startup script novnc#73:
  * add help option `--help`
  * ensure correct forwarding of shutdown signals
  * add "DEBUG" mode and move all log output to this mode
  * update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant