Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove additional signal calls in websockify that causes novnc to hang. #219

Merged
merged 1 commit into from
Jan 11, 2016

Conversation

noah8713
Copy link

@noah8713 noah8713 commented Jan 5, 2016

Openstack nova novnc-proxy services uses websockify to provide support
for nova vms using novnc proxy. At present, novnc hangs every couple of
weeks. It only resumes post restart of the novnc-proxy which is not
good. Hence, this code in websockify is updated to get rid of additional
signal calls to avoid novnc going in hang state even though process is
running. Basically, we are getting rid of existing msg and vmsg calls in
the websocket.py. This is kind of quick fix but we will need an
additional way of figuring out the logging to make it easy to trace in
case of any further failures in future.

closes bug: novnc/noVNC#556

@noah8713
Copy link
Author

noah8713 commented Jan 5, 2016

@kanaka kindly see if this works. Since the description is long, I did commit thrice as the message description was not aligning proper spaces.

@DirectXMan12 DirectXMan12 self-assigned this Jan 5, 2016
@DirectXMan12 DirectXMan12 added the bug Something isn't working label Jan 5, 2016
@DirectXMan12
Copy link
Member

@kanaka, this look good to you? I'd like to figure out a way to log the messages somehow, but I think for the time being this fix is fine with me. 👍

@noah8713 I'd prefer if you collapsed the commits together, but I can do that myself when I merge.

@noah8713
Copy link
Author

noah8713 commented Jan 6, 2016

@DirectXMan12 sounds good and thanks since you guys have admin access. :)

@jeffforbes
Copy link

This may also fix the issue I submittedL
multiprocessing exception: No Child processes #193

@noah8713
Copy link
Author

noah8713 commented Jan 8, 2016

@kanaka @DirectXMan12 : Can you please help for merging the same?

@noah8713
Copy link
Author

noah8713 commented Jan 8, 2016

squashed and merge into a single commit for my change.

Openstack nova novnc-proxy services uses websockify to provide support
for nova vms using novnc proxy. At present, novnc hangs every couple of
weeks. It only resumes post restart of the novnc-proxy which is not
good. Hence, this code in websockify is updated to get rid of additional
signal calls to avoid novnc going in hang state even though process is
running. Basically, we are getting rid of existing msg and vmsg calls in
the websocket.py. This is kind of quick fix but we will need an
additional way of figuring out the logging to make it easy to trace in
case of any further failures in future.

closes bug: novnc/noVNC#556
@noah8713
Copy link
Author

@DirectXMan12 and @kanaka any updates on this? :(

@kanaka
Copy link
Member

kanaka commented Jan 11, 2016

LGTM

@noah8713
Copy link
Author

Sweet. 👍

DirectXMan12 added a commit that referenced this pull request Jan 11, 2016
Remove logging in signal handlers
@DirectXMan12 DirectXMan12 merged commit 0b906a1 into novnc:master Jan 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants