Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable multiple targets with file-based configuration #50

Merged
merged 1 commit into from
Jul 13, 2012
Merged

Enable multiple targets with file-based configuration #50

merged 1 commit into from
Jul 13, 2012

Conversation

hsanjuan
Copy link
Contributor

...tion file.

The --target-list option is used to pass a configuration file on websockify start.

This file contains entries in the form host:port:token, one per line.

When a new connection is open (from noVNC for example), the url should look like:

ws://websockify_host:websockify_port/?token=ABCD

The token is then extracted and checked against the entries in the configuration file.

When the token matches, the connection is proxied to the host:port indicated in the file.

If the configuration file is a folder, then all the entries from files in it are read.

…uration file.

The --target-list option is used to pass a configuration file on websockify start.

This file contains entries in the form host:port:token, one per line.

When a new connection is open (from noVNC for example), the url should look like:

ws://websockify_host:websockify_port/?token=ABCD

The token is then extracted and checked against the entries in the configuration file.

When the token matches, the connection is proxied to the host:port indicated in the file.

If the configuration file is a folder, then all the entries from files in it are read.
@kanaka kanaka merged commit e17e115 into novnc:master Jul 13, 2012
@kanaka
Copy link
Member

kanaka commented Jul 13, 2012

I merged and then made some changes and cleanup. The main changes:

  • moved the config option code to websockify (websocket.py is a generic websocket library and should have no awareness of VNC targets or proxying)
  • changed the parameter name to --target-config
  • changed the config file format to be "token: host:port"

For reference, this pull is related to #3

Thanks and good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants