Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make subject an optional property of sms to make it compatible with Signal #65

Merged
merged 1 commit into from
Sep 22, 2018

Conversation

DerBeutlin
Copy link
Contributor

I use signal-back to convert signal-backup files to xml files compatible with SMS Backup & Restore. Unfortunately the subject property is missing. Therefore I would like to make the subject property optional, replacing it with the empty string if it's not available.

@novoid
Copy link
Owner

novoid commented Sep 22, 2018

Hey, I too tested signal-back to be able to use this Memacs module with it. ;-)
Unfortunately, the format seems to have changed to big extend since I first wrote the sms Module. For example, every Signal message with an "attachment" is now of type "mms" which is not supported by the memacs module yet.
Therefore, adding support for more XML elements is on my mid-term todo list.
Glad that there is another person using the same workflow ;-)

@novoid novoid merged commit 3466c11 into novoid:master Sep 22, 2018
@novoid novoid mentioned this pull request Sep 22, 2018
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants