Fix problems when locale is not en_US #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the locale is not en_US, the time string will be in another language, and Python's %c can't parse it unless it knows what locale it is. My changes pick up the system locale. Also I removed an encode() call that was not needed and was causing problems. This should even fix issue #43
bighi
commented
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the locale is not en_US, the time string will be in another language, and Python's %c can't parse it unless it knows what locale it is. This problem was making memacs_mumail not run for me, because my system is set up to use Brazilian Portuguese.
My changes pick up the system locale. Also I removed an encode() call that was not needed and was causing problems. Now it works with my pt_BR locale!
This should even fix issue #43. Maybe.