Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

note: potential pitfall for files with timestamps similar enough #8

Closed
nbehrnd opened this issue Jul 14, 2023 · 2 comments
Closed

note: potential pitfall for files with timestamps similar enough #8

nbehrnd opened this issue Jul 14, 2023 · 2 comments
Assignees
Labels

Comments

@nbehrnd
Copy link
Collaborator

nbehrnd commented Jul 14, 2023

For stamps by date2name about day and time, the current implementation of "common substring" can tap into this stamp. Actually -- extending the script's internal documentation, this already takes place with two files 2023-06-11T12.26.18 Wedding of Paula and John - Guests arriving.jpg and 2023-06-11T13.05.48 Wedding of Paula and John - Ceremony starts.jpg which share the last digit of the seconds; instead of the anticipated pattern of Wedding of Paula and John, the implementation suggests 8 Wedding of Paula and John.

Tests so far did not yield the same error for files where date2name assigned only the day alone.

The attached log reports the findings for the current version of move2archive by 2023-06-11 in an instance of Linux Debian 13/trixie (branch testing) with Python 3.11.4.

2023-07-14_report_move2archive.txt

@novoid novoid self-assigned this Jul 15, 2023
@novoid novoid added the bug label Jul 15, 2023
novoid added a commit that referenced this issue Jul 15, 2023
@novoid
Copy link
Owner

novoid commented Jul 15, 2023

Absolutely true. I recognized myself.

Didn't think that this new feature get adapted so fast. ;-) However, its idea is cool, isn't it? I wondered why I wasn't planning for that sooner.

Anyway, this issue is fixed and its implementation is much more cleaner now with the latest version. Thanks for giving me the incentive to fix that. It also annoyed me.

@nbehrnd
Copy link
Collaborator Author

nbehrnd commented Jul 17, 2023

I agree, the concept is an attractive one. Even more remarkable is the terse code to implement the functionality, considerably more condensed than what I found as «longest common subsequence» on stackoverflow about processing only two strings.

2023-07-17_longest_common_subsequence.md

@nbehrnd nbehrnd closed this as completed Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants