Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate out in DI the singleton Client from the explicit Clients #60

Closed
toddb opened this issue Aug 28, 2023 · 1 comment
Closed

Separate out in DI the singleton Client from the explicit Clients #60

toddb opened this issue Aug 28, 2023 · 1 comment

Comments

@toddb
Copy link
Collaborator

toddb commented Aug 28, 2023

The RestService client is a single and wouldn't likely to be used at the same time as the explicit clients, so let people use only what they need.

Also the singleton client can remain backwards capatible but seems like the HttpClient (Pool) is going to need to be managed via injection.
toddb pushed a commit that referenced this issue Aug 28, 2023
feat: separate out in DI the singleton Client from the explicit Clients
eb72992 
#60
@toddb toddb mentioned this issue Aug 28, 2023
Merged
wh1337 pushed a commit that referenced this issue Aug 28, 2023
@wh1337
feat: separate out in DI the singleton Client from the explicit Clients
2187c42 
#60
@toddb
Copy link
Collaborator Author

toddb commented Aug 28, 2023 •
edited
Loading

Released 0.3.1

@toddb toddb closed this as completed Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@toddb