feat: Topics #13
feat: Topics #13
Conversation
All methods are implemented as of this commit. There is still work to be done on proper error handling and documentation.
| NovuClient = novu; | ||
| } | ||
|
|
||
| public async void Dispose() |
There was a problem hiding this comment.
Any reason why this function is empty?
There was a problem hiding this comment.
When you implement the IDisposable interface on a text fixture, the method is required to be implemented as part of testing cleanup. However, we do not have anything to clean up after running this test. We have to implement IDisposable in order for xunit to pick up the fixture an use it as a dependency injection so we don't have to create new clients on each test and we can use the shared client through all tests in that class.
There was a problem hiding this comment.
Okay thanks for the clarification
| /// <example> | ||
| /// <para> | ||
| /// <code> | ||
| /// var topicRequest = new TopicCreateDto | ||
| /// { | ||
| /// Key = $"test:topic:{Guid.NewGuid().ToString()}", | ||
| /// Name = "Test Topic", | ||
| /// }; | ||
| /// | ||
| /// var topic = await client.Topic.CreateTopicAsync(topicRequest); | ||
| /// </code> | ||
| /// </para> | ||
| /// </example> | ||
| /// <param name="dto"> | ||
| /// <see cref="TopicCreateDto"/> | ||
| /// </param> | ||
| /// <returns> | ||
| /// <see cref="TopicCreateResponseDto"/> | ||
| /// </returns> |
There was a problem hiding this comment.
Any particular reason why we have the docblocks like this in different html tags?
There was a problem hiding this comment.
These generate intellisense snippets like this:
It is also required for future docfx implementation for automatic documentation.
C# Comments: https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/language-specification/documentation-comments
There was a problem hiding this comment.
We don't have them in the other code, so I was wondering why we need them all of a sudden now.
No description provided.