Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: typo #15

Merged
merged 1 commit into from
May 5, 2023
Merged

Conversation

wh1337
Copy link
Collaborator

@wh1337 wh1337 commented May 5, 2023

No description provided.

Copy link
Collaborator Author

@wh1337 wh1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went over line by line to check for more typos. Please double check me.

@wh1337 wh1337 marked this pull request as ready for review May 5, 2023 07:41
@wh1337 wh1337 requested a review from unicodeveloper May 5, 2023 07:41
@wh1337 wh1337 self-assigned this May 5, 2023
@@ -7,7 +7,7 @@ on:
env:
PROJECT_PATH: "./src/Novu/Novu.csproj"
PACKAGE_OUTPUT_DIRECTORY: ${{ github.workspace }}\output
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be backslash? or frontslash?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backslash has been working, according to the logs the part where it's failing is when attempting to upload the .nupkg to Nuget

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

@unicodeveloper unicodeveloper merged commit 76c22c6 into novuhq:main May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants