Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced RestSharp with Refit #25

Merged
merged 3 commits into from
May 8, 2023
Merged

Replaced RestSharp with Refit #25

merged 3 commits into from
May 8, 2023

Conversation

Badabum
Copy link

@Badabum Badabum commented May 5, 2023

This pr replaces RestSharp library with Refit.
Refit is a more performant library and utilizes source generation to remove a lot of boilerplate code (as can already be seeing)
Related issue: #24

Copy link
Collaborator

@wh1337 wh1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the direction this is going, however there are quite a few failing tests.

image

Can you take a look? To run the tests, create a new organization at https://web.novu.co and grab the API key, and set the NOVU_API_KEY environment variable. If you use JetBrains Rider, you can set test environment variables by going to Settings > Unit Testing > Test Runner > Environment Variables at the bottom.

jetbrains://Rider/settings?name=Build%2C+Execution%2C+Deployment--Unit+Testing--Test+Runner

@Badabum
Copy link
Author

Badabum commented May 6, 2023

@wh1337 thx for review! sure will update tests prob tomorrow or on Monday

@Badabum
Copy link
Author

Badabum commented May 8, 2023

@wh1337 I updated tests and code, so all seem good atm

@wh1337
Copy link
Collaborator

wh1337 commented May 8, 2023

Don't worry about the failing action test. It's a known issue for PRs coming in via forks. I have ran the tests locally, and they have all passed:

image

@Badabum for your contribution!

Copy link
Collaborator

@wh1337 wh1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are now passing, PR approved

@wh1337 wh1337 merged commit 4f307ae into novuhq:main May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants