-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
novu-python fails to parse response from setting push notification provider credentials #148
Comments
danbim
changed the title
novu-python fails to parse response from settings push notification provider credentials
novu-python fails to parse response from setting push notification provider credentials
Oct 31, 2023
unicodeveloper
pushed a commit
that referenced
this issue
Nov 1, 2023
# [1.10.0](v1.9.1...v1.10.0) (2023-11-01) ### Bug Fixes * [#148](#148) make webhook_url and channel optional in SubscriberChannelSettingsCredentialsDto ([a334e48](a334e48)) ### Features * **api:** add transaction id param to MessageApi list method ([4fc5dad](4fc5dad)) * **deps:** update dependency sentry-sdk to v1.33.0 ([939e10d](939e10d)) * **deps:** update dependency sentry-sdk to v1.33.1 ([7d0f327](7d0f327)) * **deps:** update dependency sphinx to v7.2.6 ([f430a40](f430a40))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The current implementation has a bug that causes unexpected behavior under specific circumstances. This issue needs to be addressed to ensure the application functions reliably in all scenarios.
To Reproduce
Steps to reproduce the behavior:
Call
SubscriberApi().credentials(user_id, provider_id, webhook_url, device_tokens)
with emptywebhook_url
but withdevice_tokens
andprovider_id='apns'
(for example) in order to set up push notifications. The request on server side will succeed but parsing the response will fail with:Expected behavior
Call succeeds and successfully parses response of type
SubscriberDto
.Screenshots
[Attach relevant screenshots, if available, to provide visual context for the issue.]
Versions (please complete the following information):
Additional context
Note to Reviewers:
I believe the fix is to make
webhook_url
andchannel
optional which makes sense to me as they won't be set if I only set up a push provider.The text was updated successfully, but these errors were encountered: