Merge pull request #3376 from shanehandley-lived/client-feed-typings

fix: Update node subscriber feed params typings
novuhq · May 10, 2023 · 1811193 · 1811193
2 parents 14ec614 + e6c66bc
commit 1811193
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/packages/node/src/lib/subscribers/subscriber.interface.ts b/packages/node/src/lib/subscribers/subscriber.interface.ts
@@ -44,6 +44,6 @@ export interface IUpdateSubscriberPreferencePayload {
 }
 export interface IGetSubscriberNotificationFeedParams {
   page?: number;
-  feedIdentifier: string;
+  feedIdentifier?: string;
   seen?: boolean;
 }
diff --git a/packages/node/src/lib/subscribers/subscribers.spec.ts b/packages/node/src/lib/subscribers/subscribers.spec.ts
@@ -154,6 +154,21 @@ describe('test use of novus node package - Subscribers class', () => {
   test('should get notification feed for subscriber correctly', async () => {
     mockedAxios.get.mockResolvedValue({});
 
+    await novu.subscribers.getNotificationsFeed(
+      'test-news-feed-subscriber',
+      {}
+    );
+
+    expect(mockedAxios.get).toHaveBeenCalled();
+    expect(mockedAxios.get).toHaveBeenCalledWith(
+      '/subscribers/test-news-feed-subscriber/notifications/feed',
+      { params: {} }
+    );
+  });
+
+  test('should get notification feed for subscriber with optional feedIdentifier', async () => {
+    mockedAxios.get.mockResolvedValue({});
+
     await novu.subscribers.getNotificationsFeed('test-news-feed-subscriber', {
       feedIdentifier: '123',
     });