Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logrocket): add request sanitizing and add username& email to sessions #2662

Merged
merged 6 commits into from
Feb 6, 2023

Conversation

Cliftonz
Copy link
Contributor

@Cliftonz Cliftonz commented Feb 1, 2023

No description provided.

@ghost
Copy link

ghost commented Feb 1, 2023

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

apps/web/src/App.tsx Outdated Show resolved Hide resolved
apps/web/src/components/auth/LoginForm.tsx Outdated Show resolved Hide resolved
.idea/misc.xml Outdated Show resolved Hide resolved
@@ -38,9 +38,31 @@ import { BrandPage } from './pages/brand/BrandPage';
import { SegmentProvider } from './store/segment.context';
import LogRocket from 'logrocket';
import setupLogRocketReact from 'logrocket-react';
import packageJson from '../package.json';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you had a chance to check if in some case this is affecting the build/dist folder structure of the web?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cliftonz his suspicion was that the package.json won't be available after the build... but I've checked it and actually the package.json file is bundled to the app as the JSON string and then parsed... it just adds ~5.14kb to the bundled main JS chunk...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LetItRock is the 5kb going to be an issue?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scopsy This should be good to merge then

Co-authored-by: Paweł Tymczuk <LetItRock@users.noreply.github.com>
@Cliftonz Cliftonz requested a review from scopsy February 5, 2023 15:23
@scopsy
Copy link
Contributor

scopsy commented Feb 5, 2023

@Cliftonz let's fix the prettier errors and feel free to merge once test passed 🎉

@Cliftonz Cliftonz merged commit 43551e9 into next Feb 6, 2023
@Cliftonz Cliftonz deleted the logrocket branch February 6, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants