Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update of integration to active did not exclude push and chat #2695

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

ainouzgali
Copy link
Contributor

What change does this PR introduce?

Why was this change needed?

Update of integration to be active did not check that if its puch/chat channel before deactivating the other same type channels

Other information (Screenshots)

@linear
Copy link

linear bot commented Feb 7, 2023

NV-1515 🐛 Bug Report: Multichannel for Push notifications doesn't work for some cases

📜 Description

Novu allows users to have multiple providers for Push notifications active at the same time (i.e. FCM and APNS). However, this fails in specific cases. While it is supported during the first time someone will configure them, it seems that is fails for future updates.

👟 Reproduction steps

  1. Connect to both FCM and APNS
  2. Check that they are both active
  3. Disable FCM
  4. Check that only APNS is active
  5. Enable FCM again
  6. APNS gets disabled
Screen.Recording.2023-01-10.at.10.45.37.AM.mov

👍 Expected behavior

Multiple providers should be allowed.

👎 Actual Behavior with Screenshots

When enabling FCM, APNS gets automatically disabled.

🤖 Node Version

ghcr.io/novuhq/novu/api:0.9.0

📃 Provide any additional context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to submit PR?

None

@scopsy scopsy merged commit 849b933 into next Feb 7, 2023
@scopsy scopsy deleted the nv-1515-bug-report-multichannel-for-push branch February 7, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NV-1515] 🐛 Bug Report: Multichannel for Push notifications doesn't work for some cases
2 participants