Nv 942 bug report no way to reset destroy the #2811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NV-942 🐛 Bug Report: No way to reset / destroy the `widget_user_auth_token` in the iFrame embed.
📜 DescriptionI have a Vue app that embeds the iFrame option for displaying the notification center. When I log out the existing user and log in as a new user, the notifications don't get updated. The 👟 Reproduction steps
👍 Expected behaviorStep 5 should result in different notifications (and 👎 Actual Behavior with ScreenshotsBoth the notifications and 💻 Operating systemMacOS 🤖 Node Version16.4 📃 Provide any additional context for the Bug.No response 👀 Have you spent some time to check if this bug has been raised before?
🏢 Have you read the Contributing Guidelines?
Are you willing to submit PR?No response |
BiswaViraj
force-pushed
the
nv-942-bug-report-no-way-to-reset-destroy-the
branch
from
e9612e4
to
a8d402b
Compare
p-fernandez
approved these changes
Feb 17, 2023
| @@ -89,6 +89,7 @@ export interface INovuProviderContext { | |||
| fetchingStrategy: IFetchingStrategy; | |||
| setFetchingStrategy: (strategy: Partial<IFetchingStrategy>) => void; | |||
| onLoad: (data: { organization: IOrganizationEntity }) => void; | |||
| logout: VoidFunction; | |||
There was a problem hiding this comment.
Is this a TypeScript built in type for void functions? I didn't know about it.
There was a problem hiding this comment.
Yes, it is a part of the DOM lib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
closes #1289
Why was this change needed?
Other information (Screenshots)