FCM support add extra options #2982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tienthanh2509 I just noticed the issue you are trying to close was assigned to a different contributor. The PR was added here: #2979 |
p-fernandez
suggested changes
Mar 9, 2023
|
@tienthanh2509 PR was merged. You can edit this PR based on latest |
|
Hi @p-fernandez POST /api/v1/events/trigger HTTP/1.1
Content-Type: application/json
Authorization: ApiKey redacted
Host: 192.168.128.62:3080
Content-Length: 792
{
"name": "some-template",
"to": {
"subscriberId": "redacted"
},
"payload": {
"action_type": "some data"
},
"overrides": {
"fcm": {
"type": "data",
"android": {
"data": {
...
},
"priority": "high"
},
"apns": {
"headers": {
"apns-priority": "5"
},
"payload": {
...
}
}
}
}
} |
p-fernandez
suggested changes
Mar 9, 2023
- iOS with headers - Android with priority - Add test cases for FCM provider
tienthanh2509
commented
Mar 10, 2023
There was a problem hiding this comment.
The PR was cleaned up due to duplicate #2979
Only additional fields was added
p-fernandez
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Support adding additional options for FCM message
FCM option with analytics_labelIt already done on feat: Add fcmOptions to Firebase provider #2979apnswith additional headers include priority header, Ref https://developer.apple.com/documentation/usernotifications/setting_up_a_remote_notification_server/sending_notification_requests_to_apnsWhy was this change needed?
Closes #2233, #2965
Other information (Screenshots)
add fcmOptionsIt already done on feat: Add fcmOptions to Firebase provider #2979