feat(web): integrations store modal show the drawer over the integrations list #3032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LetItRock
commented
Mar 16, 2023
Comment on lines
+8
to
+10
| const DescriptionHolder = styled.div` | ||
| max-width: 220px; | ||
| `; |
There was a problem hiding this comment.
added here some small updates like allowing to override CSS
Comment on lines
+274
to
+279
| <ConfigureProviderButton | ||
| onClick={() => { | ||
| setIntegrationsModalVisible(true); | ||
| setPopoverOpened(false); | ||
| }} | ||
| > |
There was a problem hiding this comment.
when modal is shown hide the configure provider popover
Comment on lines
+67
to
+70
| }, [isFormOpened, setProvider, setFormIsOpened, closeIntegration]); | ||
|
|
||
| const handleKeyDown = useCallback( | ||
| (e) => { | ||
| useEffect(() => { | ||
| const handleKeyDown = (e) => { |
There was a problem hiding this comment.
fixed some issues with handling Esc button
Comment on lines
+149
to
+157
| <Drawer | ||
| opened={isFormOpened} | ||
| position="right" | ||
| onClose={handleCloseForm} | ||
| withOverlay={false} | ||
| withCloseButton={false} | ||
| closeOnEscape={false} | ||
| classNames={drawerClasses} | ||
| > |
There was a problem hiding this comment.
the integration settings is shown in the drawer
| </MantinePopover.Dropdown> | ||
| </MantinePopover> | ||
| )} | ||
| </UnstyledButtonStyled> | ||
| <IntegrationsStoreModal |
There was a problem hiding this comment.
moved the modal outside, because we don't want receive the mouse events on the node button when hovering over the modal
…ore' into nv-1850-integrations-store-modal-show-drawer
djabarovgeorge
approved these changes
Mar 16, 2023
…ore' into nv-1850-integrations-store-modal-show-drawer
Base automatically changed from
nv-1785-configure-provider-popover-with-integrations-store
to
getting-started-flow
March 17, 2023 09:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
In the Integrations Store modal, we will show the integration settings form in the drawer that will be shown when clicking on the integration tile. The drawer will be rendered over the integrations list.
Why was this change needed?
This PR is a part of improvements over the onboarding process.
Other information (Screenshots)
Screen.Recording.2023-03-16.at.14.30.22.mov