Add message count limit #3272
Merged
Add message count limit #3272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-message-count-limit
LetItRock
reviewed
Apr 25, 2023
apps/api/src/app/messages/usecases/get-messages/get-messages.command.ts
Outdated
Show resolved
Hide resolved
apps/api/src/app/messages/usecases/get-messages/get-messages.usecase.ts
Outdated
Show resolved
Hide resolved
apps/widget/cypress/plugins/index.ts
Outdated
Comment on lines
115
to
119
| async awaitRunningJobs({ templateId, organizationId }: { templateId: string; organizationId: string }) { | ||
| await awaitRunningJobs({ apiKey: config.env.API_URL, templateId, organizationId }); | ||
|
|
||
| return true; | ||
| }, |
There was a problem hiding this comment.
you don't need to have this wrapper function, instead assign the default value to the awaitRunningJobs:132, like
async function awaitRunningJobs({
apiKey = config.env.API_URL,
...
There was a problem hiding this comment.
Created this one to use it in notifications-list.spec.ts in order to try to solve the flaky tests in the CI. :(
There was a problem hiding this comment.
sorry what I meant is that you don't have to call awaitRunningJobs in line 116... instead you can do:
const session = new UserSession(serverUrl);
await session.awaitRunningJobs(templateId, undefined, 0, organizationId);
like you don't need to have that additional function awaitRunningJobs
LetItRock
approved these changes
Apr 26, 2023
# Conflicts: # apps/api/src/app/subscribers/subscribers.controller.ts # apps/api/src/app/widgets/usecases/get-notifications-feed/get-notifications-feed.usecase.ts # apps/api/src/app/widgets/widgets.controller.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
In this PR we introduce the count limit param.
Why was this change needed?
We need this additional limit query option, in order to reduce the number of scanned objects/returned on MongoDB.
Other information (Screenshots)