Nv 2578 add removeallnotifications method in headless package #3829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NV-2578 Add removeAllNotifications method in headless package
What?We recently added https://docs.novu.co/notification-center/react/api-reference#useremoveallnotifications https://docs.novu.co/notification-center/react/api-reference#the-hook-return-interface Why? (Context)This method is missing in Definition of Done
|
github-actions
bot
added
the
documentation
BiswaViraj
commented
Jul 20, 2023
| @@ -1149,11 +1145,6 @@ describe('headless.service', () => { | |||
|
|
|||
| describe('markAllMessagesAsSeen', () => { | |||
| test('calls markAllMessagesAsSeen successfully', async () => { | |||
| const updatedNotification = { | |||
There was a problem hiding this comment.
removed unused variable
| @@ -1085,11 +1086,6 @@ describe('headless.service', () => { | |||
|
|
|||
| describe('markAllMessagesAsRead', () => { | |||
| test('calls markAllMessagesAsRead successfully', async () => { | |||
| const updatedNotification = { | |||
There was a problem hiding this comment.
removed unused variable
| @@ -1 +1,2 @@ | |||
| export * from './headless.service'; | |||
| export * from './types'; | |||
There was a problem hiding this comment.
Exported the types to be accessible in the package imports
| @@ -1 +1,2 @@ | |||
| export * from './query-keys'; | |||
| export * from './types'; | |||
There was a problem hiding this comment.
Exported the types to be accessible in the package imports
…-headless-package
…-headless-package
…-headless-package
scopsy
approved these changes
Jul 24, 2023
scopsy
deleted the
nv-2578-add-removeallnotifications-method-in-headless-package
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
removeAllNotificationsmethod to the Headless serviceremoveAllNotificationsWhy was this change needed?
Other information (Screenshots)