Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add override layout in trigger functionality #3961

Conversation

ainouzgali
Copy link
Contributor

@ainouzgali ainouzgali commented Aug 13, 2023

What change does this PR introduce?

allow to override the layoutIdentifier with overrides property

Note - I am still working on adding tests, I am not sure yet how to check in a test which layout was actually executed as we don't save the resulting content.

Why was this change needed?

Other information (Screenshots)

@linear
Copy link

linear bot commented Aug 13, 2023

NV-2691 Allow override layout functionality on trigger by "layoutIdentifier"

  • allow to override the layoutIdentifier with overrides property
  • add appropriate execution detail log
  • make necessary changes to node sdk
  • cover the functionality with tests
  • add section in docs

@ainouzgali ainouzgali self-assigned this Aug 13, 2023
Copy link
Contributor

@LetItRock LetItRock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 14, 2023
@ainouzgali ainouzgali merged commit a9cc149 into nv-2690-add-identifier-field-to-layouts-schemeapi-migration Aug 14, 2023
20 checks passed
@ainouzgali ainouzgali deleted the nv-2691-allow-override-layout-functionality-on-trigger-by branch August 14, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation @novu/worker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants