Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: so add a provider is not displayed in empty state #3985

Conversation

davidsoderberg
Copy link
Contributor

Screenshot 2023-08-16 at 12 40 01 Screenshot 2023-08-16 at 12 40 57

@linear
Copy link

linear bot commented Aug 16, 2023

NV-2477 Integrations Store - remove `Add provider` button in the empty state

What?

When debugging the current flow in the cycle I found that having them both was a bit confusing. maybe in the empty state, we could remove this component so the user could be more confused about the center of the page.

image.png

Apologies for raising it only now, raising it here because the priority is super small and if any change will be needed it could shift to polishing in another cycle that is why I raised it here and not on the Figma.

Definition of done

  • the "Add a provider" button is removed when an empty state is shown to the user

@davidsoderberg davidsoderberg added this pull request to the merge queue Aug 17, 2023
Merged via the queue into next with commit 9b10276 Aug 17, 2023
23 checks passed
@davidsoderberg davidsoderberg deleted the nv-2477-integrations-store-remove-add-provider-button-in-the-empty branch August 17, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants