fix/docs: update README component links #4389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-w-nick
changed the title
nick-w-nick
changed the title
scopsy
approved these changes
Oct 8, 2023
|
Thank you so much @nick-w-nick 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
This PR fixes the links to the individual UI framework SDK documentation pages.
Why was this change needed?
The current links were pointing to generic pages or had links that redirect to generic pages.
Other information (Screenshots)
For "React Component", https://docs.novu.co/notification-center/getting-started is too generic and mostly unhelpful on its own and still requires the user to find the React documentation from there.
For "Vue Component", https://docs.novu.co/notification-center/vue-component just redirects to https://docs.novu.co/getting-started/introduction, which is also too generic.
For "Angular Component", https://github.com/novuhq/novu/tree/next/packages/notification-center-angular links to an unhelpful README that would confuse most users.