Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): Remove multi provider feature flag #4402

Merged
merged 8 commits into from
Oct 25, 2023

Conversation

rifont
Copy link
Contributor

@rifont rifont commented Oct 4, 2023

What change does this PR introduce?

This PR removes the multi-provider feature flag from the Web package.

Why was this change needed?

The multi-provider feature has been successfully implemented in production for an adequate length of time.

Other information (Screenshots)

The API and Worker packages are dealt with in #4403

@linear
Copy link

linear bot commented Oct 4, 2023

NV-2907 Remove the IS_MULTI_PROVIDER_CONFIGURATION_ENABLED feature flag

What?

We would like to remove the IS_MULTI_PROVIDER_CONFIGURATION_ENABLED feature flag and all associated "false" statement code.

Why? (Context)

The feature flag IS_MULTI_PROVIDER_CONFIGURATION_ENABLED is running on the prod for quite some time.

Definition of Done

  • the feature flag IS_MULTI_PROVIDER_CONFIGURATION_ENABLEDand all associated "false" statement code is removed

@rifont rifont changed the title Nv 2907 web remove multi provider ff chore(web): Remove multi provider feature flag Oct 4, 2023
@rifont rifont marked this pull request as ready for review October 5, 2023 15:46
@rifont rifont requested a review from LetItRock October 5, 2023 15:46
@rifont rifont self-assigned this Oct 5, 2023
@github-actions github-actions bot added the stale Pull Request that needs to be reviewed label Oct 19, 2023
Copy link
Contributor

@p-fernandez p-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

import { ISelectPrimaryIntegrationModalProps, SelectPrimaryIntegrationModal } from './SelectPrimaryIntegrationModal';

export const useSelectPrimaryIntegrationModal = () => {
const [opened, { open, close }] = useDisclosure(false);
const [isOpened, { open, close }] = useDisclosure(false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subtle but good change in my opinion. 👍🏻

@github-actions github-actions bot removed the stale Pull Request that needs to be reviewed label Oct 21, 2023
@rifont rifont merged commit 1a04a6d into next Oct 25, 2023
19 checks passed
@rifont rifont deleted the NV-2907-web-remove-multi-provider-ff branch October 25, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants