feat(notification-center-angular): Support Angular versions 15+ #4518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NV-1919 The `notification-center-angular` package is not working with the latest Angular CLI generated project
Reproduction StepsUse the Angular CLI to generate the new project, then install the At the end you won't see the Notification Center component in the app, and there will be error in the console. Screenshot 2023-03-28 at 10.39.38.png Also the example app in the main repo is not working as well. Expected BehaviourThe Notification Center component should be rendered and should work well. |
rifont
changed the title
rifont
changed the title
rifont
commented
Oct 16, 2023
packages/notification-center-angular/projects/notification-center-angular/ng-package.json
Show resolved
Hide resolved
packages/notification-center-angular/projects/notification-center-angular/package.json
Outdated
Show resolved
Hide resolved
packages/notification-center-angular/projects/notification-center-angular/package.json
Show resolved
Hide resolved
packages/notification-center-angular/projects/notification-center-angular/tsconfig.lib.json
Outdated
Show resolved
Hide resolved
This was referenced Oct 16, 2023
rifont
changed the title
rifont
commented
Oct 16, 2023
rifont
commented
Oct 17, 2023
|
@scopsy @LetItRock this PR has been updated to keep the current |
LetItRock
approved these changes
Oct 23, 2023
packages/notification-center-angular/projects/notification-center-angular/README.md
Outdated
Show resolved
Hide resolved
rifont
commented
Oct 23, 2023
packages/notification-center-angular/projects/notification-center-angular/README.md
Outdated
Show resolved
Hide resolved
rifont
commented
Oct 23, 2023
packages/notification-center-angular/projects/notification-center-angular/README.md
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
@angular/*peer dependencies@types/reactas a dependency to eliminate a step for Angular clients. This isn't ideal, but neither is shipping a full React dep in an Angular project. This is a viable DX improvement until we support Angular natively.Why was this change needed?
@angular/*dependency to work correctly, so we fix this by specifying these Angular dependencies as peerCloses #3988.
Other information (Screenshots)
Successfully verified to be working with Angular 15, 16, & prerelease of 17 via a test NPM package (https://www.npmjs.com/package/rifont-notification-center-angular)
V15 (Currently LTS, EOL in 3 weeks)
V16 (Currently LTS)
V17 (tested with pre-release, GA is in 3 weeks)
Package Publish dry run
Lerna version bump testing
ReadMe Update
