Add Trigger Identifier to the Subscriber Preferences response #4559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NV-2842 Add Trigger Identifier to the Subscriber Preferences response
What?Add the Why?Some users would love to filter the preferences based on the identifier of the trigger. Definition of Done
|
…iber-preferences-response
djabarovgeorge
commented
Oct 22, 2023
Comment on lines
-124
to
-133
|
|
||
| export interface ITriggerVariable { | ||
| name: string; | ||
| type: TemplateVariableTypeEnum; | ||
| } | ||
|
|
||
| export interface ITriggerReservedVariable { | ||
| type: TriggerContextTypeEnum; | ||
| variables: ITriggerVariable[]; | ||
| } |
There was a problem hiding this comment.
Do we have a reason for having those in the DAL?
i noticed that they are duplicated and not aligned with the interface in the Shared lib.
…iber-preferences-response
LetItRock
approved these changes
Oct 23, 2023
| @@ -253,6 +254,7 @@ function mapTemplateConfiguration( | |||
| name: template.name, | |||
| tags: template?.tags || [], | |||
| critical: template.critical != null ? template.critical : true, | |||
| triggers: template.triggers, | |||
There was a problem hiding this comment.
can you please update the Swagger API response in the subscriber's controller?
There was a problem hiding this comment.
Definitely! i knew I forgot something here 🤦♂️
…iber-preferences-response
…iber-preferences-response
scopsy
approved these changes
Oct 24, 2023
djabarovgeorge
deleted the
nv-2842-add-trigger-identifier-to-the-subscriber-preferences-response
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Add the triggers field to be part of the response to the query. The mapping functionality is required.
Why was this change needed?
Some users would love to filter the preferences based on the identifier of the trigger.
Other information (Screenshots)
Created this initial solution and still have a couple of questions left hanging, will change this PR to ready from draft state after i figure it out.
closes #4417