-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Apply rate limit decorators to api controllers and methods #4915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…future rate limited protocols
…fault-api-rate-limits use-case
…vuhq/novu into nv-3059-get-rate-limit-use-case
…ollers and methods
…source-protection
NV-3062 🏎️ API Resource Protection
What?
Why? (Context)In order to rate limit access to specific resources in the service, we must apply the custom Rate Limiting controller to specific resources to allocate access to them into a specific bucket. Definition of Done
|
rifont
changed the title
feat(api): Apply rate limit category and cost decorators to api controllers and methods
feat(api): Apply rate limit decorators to api controllers and methods
Nov 29, 2023
…source-protection
…source-protection
Cliftonz
approved these changes
Nov 29, 2023
…source-protection
…source-protection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
/events
/events/trigger
- [Bulk]/events/broadcast
- [Bulk]/subscribers
/subscribers/bulk
- [Bulk]/tenants
/topics
/changes
/changes/bulk/apply
- [Bulk]/invites
/invites/bulk
- [Bulk]Why was this change needed?
In order to provide a fair service to all clients, some API resources must have a differing category and cost applied given that underlying resource consumption can vary. This change colocates resources and methods whose category falls into a similar infrastructure bucket, and applies bulk cost to bulk endpoints which place a higher load on infrastructure.
Other information (Screenshots)
N/A