Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provider): add ring central provider (#77) #5147

Merged

Conversation

KelvisGama
Copy link
Contributor

What change does this PR introduce?

Add RingCentral provider implementation

Why was this change needed?

Closes #77

Other information (Screenshots)

Integration Store

image

Workflow

image

Activity Feed

image

Copy link

netlify bot commented Feb 1, 2024

👷 Deploy request for dev-web-novu pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 0656fb7

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KelvisGama could you please add square logo svgs in dark and light square folders?

Ref:- https://docs.novu.co/community/add-a-new-provider#add-provider-logos

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jainpawan21 Those already exist.
They are added on e9abbd2

auto-merge was automatically disabled February 5, 2024 16:55

Head branch was pushed to by a user without write access

@Cliftonz Cliftonz dismissed jainpawan21’s stale review February 5, 2024 19:24

re looked over request

@Cliftonz
Copy link
Contributor

Cliftonz commented Feb 5, 2024

@KelvisGama Please add the words missing in the spell check pipeline to this PR
https://github.com/novuhq/novu/actions/runs/7788071814/job/21242085435?pr=5147

@KelvisGama
Copy link
Contributor Author

@KelvisGama Please add the words missing in the spell check pipeline to this PR https://github.com/novuhq/novu/actions/runs/7788071814/job/21242085435?pr=5147

Done.

@Cliftonz Cliftonz merged commit d3b61d1 into novuhq:next Feb 7, 2024
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NV-181] - Add Ringcentral sms provider
3 participants