Nv 3475 - typeerror cannot create property buttons on string #5172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for dev-web-novu failed.
|
djabarovgeorge
commented
Feb 8, 2024
Comment on lines
+21
to
+23
| if ((command?.cta?.action as IMessageAction | undefined | '') === '') { | ||
| throw new ApiException('Please provide a valid CTA action'); | ||
| } |
There was a problem hiding this comment.
I do not like this solution but this would be the best way we could validate and alert the API user with a proper message, and this is because we do not support nested command validation REF, I will raise the topic with the team.
djabarovgeorge
commented
Feb 8, 2024
| @@ -41,7 +41,7 @@ export function InAppWidgetPreview({ | |||
|
|
|||
| function onRemoveTemplate() { | |||
| setIsButtonsTemplateSelected(false); | |||
| onChange(''); | |||
| onChange({}); | |||
There was a problem hiding this comment.
This solved the web side issue.
LetItRock
deleted the
nv-3475-typeerror-cannot-create-property-buttons-on-string
branch
LetItRock
added a commit
that referenced
this pull request
Feb 9, 2024
…property-buttons-on-string Nv 3475 - typeerror cannot create property buttons on string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Resolve the issue where the user is storing an invalid value under message-template.cta.action
Why was this change needed?
bug
Other information (Screenshots)