Nv 3005 the new sms editor #5197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ainouzgali
commented
Feb 15, 2024
Comment on lines
+28
to
+31
| const { pathname } = useLocation(); | ||
|
|
||
| const isPreviewPath = pathname.endsWith('/preview'); | ||
| const showEditOverlay = isHovered && isPreviewPath; |
There was a problem hiding this comment.
Show the edit option only when in the preview route - not in the editor
Comment on lines
+34
to
+41
| if (!showPreviewAsLoading) { | ||
| getSmsPreview({ | ||
| content: previewData.current.templateContent, | ||
| payload: previewData.current.processedVariables, | ||
| locale, | ||
| }); | ||
| } | ||
| }, [locale, previewData, getSmsPreview, showPreviewAsLoading]); |
There was a problem hiding this comment.
trigger use effect when showPreviewAsLoading is toggled, and call the preview endpoint only when typing in editor has timed out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
The new SMS editor layout with the preview
Why was this change needed?
Other information (Screenshots)