fix: provider sidebar from 'get-started' screen #5535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for novu-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
scopsy
approved these changes
May 9, 2024
scopsy
deleted the
nv-3745-fix-auto-scroll-on-channel-selector-sidebar-tests
branch
SokratisVidros
pushed a commit
that referenced
this pull request
May 13, 2024
Co-authored-by: Adam Chmara <adam@novu.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
The sidebar component needs to behave differently based on from where its called:
/get-startedscreen, the URL needs to stay the same to not cancel out the "integrations" modalscrollToprop/url param changingI think the future goal here could be to avoid modal on top of the modal in the "Get started" screen and just use the "Integrations store" screen, that would reduce the number of tests since
integrations-list-pageandintegrations-list-modalare almost identical and needs to be maintained.