feat(ee-auth): Use clerk in the enterprise version #5755

ChmaraX · 2024-06-17T14:04:12Z

What changed? Why was the change needed?

Notion Document explaning the change in detail:
https://www.notion.so/novuhq/Migration-to-Clerk-Auth-API-e097841461d14e51922cc9074b706695?pm=c

TODO:

add new e2e tests for the replaced implementation
revise existing e2e tests
add new e2e tests for clerk webhooks
solve environment switch on the web side
add another feature flag to be able to disable this change while having EE = true
there are new e2e-ee tests from feat(root): include local tunnel work #5698 which are now redundant after this change - we can probably delete them here

Related enterprise PR

https://github.com/novuhq/packages-enterprise/pull/147

apps/api/src/app/auth/legacy-ee-auth/auth.controller.ts

apps/api/e2e/setup.ts

apps/api/package.json

apps/api/src/app.module.ts

apps/api/src/app/auth/legacy-ee-auth/auth.controller.ts

.github/workflows/on-pr.yml

ChmaraX added 30 commits May 30, 2024 09:45

feat(auth): use clerk auth strategy in enterprise version

6509087

feat(auth): update enterprise submodule pointer and deps

4a4621e

feat(auth): initialize auth module conditionally

31ba951

feat(auth): replace auth module and service with custom ee impl

1d406d4

feat(auth): rename comm auth; include widgets module in ee

76a8409

feat(auth): fix comm auth provider injection

21e6560

feat(auth): add ee user repository switch

c1716d6

feat(auth): add ee member repository switch

1a794d1

feat(auth): add ee organization repository switch

2085dc4

refactor(auth): remove unused methods from user repository

c0a9014

feat(auth): add clerk client

3fa5e9a

refactor(auth): replace find-one cases with find-by-id

4d35040

feat(auth): prevent circular package deps by custom providers

4c82645

refactor(auth): remove unused methods

fe8500e

refactor(auth): replace find-one by find-by-id (orgs)

ee1d767

feat(auth): extends repo interface with base repository

90f92f8

chore(source): point to latest ee package

c0fde81

feat(auth): enforce impl of all repository methods in ee

acee7f9

feat(auth): add member repository clerk integration

e92c3c0

chore(deps): update ee package pointer

37895a2

refactor(mongoose): remove redundant parameters from update

ed54b81

feat(auth): add clerk user repository

d321a0d

feat(auth): add custom ee auth service and controller

60587f9

feat(auth): simplify injection of providers

b07c5c8

feat(auth): add api key and subscriber strategies to ee

e0256a6

feat(test): fix api unit tests

28e6251

feat(auth): init of ee related classes in tests

6afbef0

feat(auth): fix ee auth service init; remove ee auth controller

05bc3a2

feat(auth): bring back created by field in org entity

9354a00

feat(auth): replace user module with ee version

26abdff

ChmaraX temporarily deployed to Linting July 9, 2024 08:45 — with GitHub Actions Inactive

ChmaraX had a problem deploying to Linting July 9, 2024 08:45 — with GitHub Actions Failure

feat: add legacy ee auth module for backwards compatibility

37cb40e

ChmaraX temporarily deployed to Linting July 9, 2024 10:06 — with GitHub Actions Inactive

ChmaraX had a problem deploying to Linting July 9, 2024 10:06 — with GitHub Actions Failure

ChmaraX temporarily deployed to Linting July 9, 2024 10:06 — with GitHub Actions Inactive

Merge branch 'next' into nv-1699-migrate-authn-authz-to-clerkcom-api

6fe2037

ChmaraX had a problem deploying to Linting July 9, 2024 10:09 — with GitHub Actions Failure

ChmaraX temporarily deployed to Linting July 9, 2024 10:09 — with GitHub Actions Inactive

github-advanced-security bot found potential problems Jul 9, 2024

View reviewed changes

apps/api/src/app/auth/legacy-ee-auth/auth.controller.ts Dismissed Show dismissed Hide dismissed

Merge branch 'next' into nv-1699-migrate-authn-authz-to-clerkcom-api

512cf3f

ChmaraX had a problem deploying to Linting July 9, 2024 15:46 — with GitHub Actions Failure

ChmaraX temporarily deployed to Linting July 9, 2024 15:46 — with GitHub Actions Inactive

Merge branch 'next' into nv-1699-migrate-authn-authz-to-clerkcom-api

7b8cff5

ChmaraX temporarily deployed to Linting July 10, 2024 07:19 — with GitHub Actions Inactive

ChmaraX had a problem deploying to Linting July 10, 2024 07:19 — with GitHub Actions Failure

ChmaraX temporarily deployed to Linting July 10, 2024 07:19 — with GitHub Actions Inactive

chore: pnpm-lock

d063149

ChmaraX temporarily deployed to Linting July 10, 2024 07:21 — with GitHub Actions Inactive

ChmaraX had a problem deploying to Linting July 10, 2024 07:21 — with GitHub Actions Failure

ChmaraX temporarily deployed to Linting July 10, 2024 07:21 — with GitHub Actions Inactive

ChmaraX temporarily deployed to Linting July 10, 2024 07:43 — with GitHub Actions Inactive

ChmaraX had a problem deploying to Linting July 10, 2024 07:43 — with GitHub Actions Failure

SokratisVidros approved these changes Jul 10, 2024

View reviewed changes

apps/api/e2e/setup.ts Show resolved Hide resolved

apps/api/package.json Show resolved Hide resolved

apps/api/src/app.module.ts Show resolved Hide resolved

apps/api/src/app/auth/legacy-ee-auth/auth.controller.ts Show resolved Hide resolved

.github/workflows/on-pr.yml Show resolved Hide resolved

ChmaraX merged commit d03da1b into next Jul 10, 2024
30 of 31 checks passed

ChmaraX deleted the nv-1699-migrate-authn-authz-to-clerkcom-api branch July 10, 2024 08:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ee-auth): Use clerk in the enterprise version #5755

feat(ee-auth): Use clerk in the enterprise version #5755

ChmaraX commented Jun 17, 2024 •

edited

Loading

feat(ee-auth): Use clerk in the enterprise version #5755

feat(ee-auth): Use clerk in the enterprise version #5755

Conversation

ChmaraX commented Jun 17, 2024 • edited Loading

What changed? Why was the change needed?

Related enterprise PR

ChmaraX commented Jun 17, 2024 •

edited

Loading