-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image error in Share and Embed section of Contributors profile #40
Comments
I see it is only on profiles of new contributors may be due to a background process to generate the image. |
But the generated image is better .. That means we should show GitHub avatar until the image has been generated .. that ll be better |
That's a great catch! 👏 And it's really that unpleasant thing that needs to be fixed! But I'm not sure whether I see several simple solutions at the moment:
|
Just need to check why the badge cron is not running
…On Wed, 5 Oct 2022 at 14:56 Andrew Golovanov ***@***.***> wrote:
That's a great catch! 👏 And it's really that unpleasant thing that needs
to be fixed! But I'm not sure whether avatar or siteImage should be shown
instead of image, first of all these images are not of the right size,
secondly it will lead to new open issue - hello guys, why I've some strange
image when I want to share? - this will confuse users, and it also does not
give an understanding of whether there will ever be a correct image like
other users or it is a bug - which leads to the same new open issue for
fixing
I see several simple solutions at the moment:
1. Checking if the image is available to share - if the image is not
yet generated, we hide the user page on the page until the image is ready
(I don't see anything wrong with this, to me this is a normal process -
preparing data takes some time to display correctly later)
2. Add a stub for the modal window in the form - we're already working
on your unique image that you can share soon, please come back a bit later
to get it, thanks!
3. Hide the share buttons until we have access to the image
—
Reply to this email directly, view it on GitHub
<#40 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AX32VBUGHVSAZ7RAXIFORU3WBUYBVANCNFSM6AAAAAAQ3Q53FY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Please assign this issue to me.
Thank you
The text was updated successfully, but these errors were encountered: