Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image error in Share and Embed section of Contributors profile #40

Closed
diwash007 opened this issue Oct 3, 2022 · 4 comments
Closed

Image error in Share and Embed section of Contributors profile #40

diwash007 opened this issue Oct 3, 2022 · 4 comments

Comments

@diwash007
Copy link
Contributor

image
image

Please assign this issue to me.
Thank you

@diwash007
Copy link
Contributor Author

I see it is only on profiles of new contributors may be due to a background process to generate the image.
Should we instead show the GitHub avatar like that of og:image or what should we do here? @nevo-david

@diwash007
Copy link
Contributor Author

But the generated image is better .. That means we should show GitHub avatar until the image has been generated .. that ll be better

@andrewgolovanov
Copy link
Member

That's a great catch! 👏 And it's really that unpleasant thing that needs to be fixed! But I'm not sure whether avatar or siteImage should be shown instead of image, first of all these images are not of the right size, secondly it will lead to new open issue - hello guys, why I've some strange image when I want to share? - this will confuse users, and it also does not give an understanding of whether there will ever be a correct image like other users or it is a bug - which leads to the same new open issue for fixing

I see several simple solutions at the moment:

  1. Checking if the image is available to share - if the image is not yet generated, we hide the user page on the page until the image is ready (I don't see anything wrong with this, to me this is a normal process - preparing data takes some time to display correctly later)
  2. Add a stub for the modal window in the form - we're already working on your unique image that you can share soon, please come back a bit later to get it, thanks!
  3. Hide the share buttons until we have access to the image

@nevo-david
Copy link
Contributor

nevo-david commented Oct 5, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants