histogram: add TimeHistogram #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change pulls in the TimeHistogram from https://github.com/Noah-Kennedy/prometheus-client-utils.git, allowing us to get rid of tha crate, and changes the HistogramTimer to use that histogram instead of the one from the prometheus_client crate. It also makes a minor change to CI, adding a new job which runs `cargo check` on each feature.
nox
reviewed
Jun 14, 2023
nox
reviewed
Jun 14, 2023
Noah-Kennedy
force-pushed
the
noah/fast-histogram
branch
from
3bbe652
to
c0c49dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change pulls in the TimeHistogram from https://github.com/Noah-Kennedy/prometheus-client-utils.git, allowing us to get rid of tha crate, and changes the HistogramTimer to use that histogram instead of the one from the prometheus_client crate.
It also makes a minor change to CI, adding a new job which runs
cargo checkon each feature.