Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --tag to allow installing a specific version on Android #9

Merged
merged 6 commits into from
Apr 2, 2023
Merged

Add --tag to allow installing a specific version on Android #9

merged 6 commits into from
Apr 2, 2023

Conversation

nekomekoraiyuu
Copy link
Contributor

  • Bash sensei overwork
  • Yanu now allows you to install older versions
  • Minor fool proofing?

@nozwock
Copy link
Owner

nozwock commented Mar 26, 2023 •
edited
Loading

How about just having a simple -v arg instead?
A prompt gets in the way of the user. This is for edge cases, doesn't feel like something which should be at everyone's face?

@nozwock
Copy link
Owner

nozwock commented Mar 26, 2023

This also also over complicates the scripts and adds unnecessary maintenance overhead.

@nekomekoraiyuu
Copy link
Contributor Author

This also also over complicates the scripts and adds unnecessary maintenance overhead.

real

@nekomekoraiyuu
Copy link
Contributor Author

This also also over complicates the scripts and adds unnecessary maintenance overhead.

hmm i thought it'd be useful with -i interactive flag but sure

@nozwock
Copy link
Owner

nozwock commented Mar 26, 2023 •
edited
Loading

This also also over complicates the scripts and adds unnecessary maintenance overhead.

hmm i thought it'd be useful with -i interactive flag but sure

Maybe that'll be good, but make these version prompt changes in a separate file and then source that file in this file.
Preferably have a function which prompts and returns the chosen version number and then do simple substitution in this file?

nekomekoraiyuu
nekomekoraiyuu commented Mar 26, 2023
View reviewed changes
Copy link
Contributor Author

@nekomekoraiyuu nekomekoraiyuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed de error indeed

@nekomekoraiyuu
Copy link
Contributor Author

real

@nekomekoraiyuu nekomekoraiyuu mentioned this pull request Mar 28, 2023
Closed
@nekomekoraiyuu @nozwock
bootstrap: QOL Update
3f18946 
- Add --tag flag to download the old version of yanu
- Code cleanup

---------

Co-authored-by: nozwock <57829219+nozwock@users.noreply.github.com>
@nekomekoraiyuu
Copy link
Contributor Author

Resolved conflicts

@nozwock nozwock changed the title Bootstrap: QOL Update Add --tag to allow installing specific versions Apr 2, 2023
@nozwock nozwock changed the title Add --tag to allow installing specific versions Add --tag to allow installing a specific version on Android Apr 2, 2023
nozwock
nozwock approved these changes Apr 2, 2023
View reviewed changes
Copy link
Owner

@nozwock nozwock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the re-installation for eget, looks good to go.

resources/scripts/yanu-bootstrap-termux_proot.sh Outdated Show resolved Hide resolved
@nozwock nozwock merged commit 3e99367 into nozwock:main Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nozwock nozwock nozwock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nekomekoraiyuu @nozwock