Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allocate header map in NewRequest unless it is actually used #10

Closed
derekperkins opened this issue Nov 6, 2017 · 1 comment · Fixed by #31
Closed

Don't allocate header map in NewRequest unless it is actually used #10

derekperkins opened this issue Nov 6, 2017 · 1 comment · Fixed by #31

Comments

@derekperkins
Copy link
Collaborator

No description provided.

@josephbergevin
Copy link
Collaborator

This would mean each RequestOption that is adding a header would need to run a nil map check before adding any headers every time.
Maybe we switch the Request.headers type to []header. struct header type {key, value string} Thoughts @derekperkins?

@josephbergevin josephbergevin mentioned this issue Nov 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

changed Request.headers from map to slice nozzle/fetcher
2 participants
@josephbergevin @derekperkins