Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed Request.headers from map to slice #31

Merged
merged 1 commit into from
Nov 20, 2017

Conversation

josephbergevin
Copy link
Collaborator

closes #10

@codecov
Copy link

codecov bot commented Nov 20, 2017

Codecov Report

Merging #31 into master will increase coverage by 0.57%.
The diff coverage is 64.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   38.41%   38.98%   +0.57%     
==========================================
  Files           7        7              
  Lines         453      454       +1     
==========================================
+ Hits          174      177       +3     
+ Misses        251      250       -1     
+ Partials       28       27       -1
Impacted Files Coverage Δ
request.go 15.89% <64.28%> (+1.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a27c151...49a1a53. Read the comment docs.

@josephbergevin josephbergevin merged commit ec52824 into master Nov 20, 2017
@josephbergevin josephbergevin deleted the new-request-headers branch November 20, 2017 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't allocate header map in NewRequest unless it is actually used
1 participant