Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for WithTimeout and WithDeadline #13

Merged
merged 1 commit into from
Nov 7, 2017

Conversation

derekperkins
Copy link
Collaborator

This is just a convenience wrapper around context.WithTimeout/WithDeadline

@codecov
Copy link

codecov bot commented Nov 6, 2017

Codecov Report

Merging #13 into master will decrease coverage by 0.76%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
- Coverage   21.71%   20.94%   -0.77%     
==========================================
  Files           6        6              
  Lines         327      339      +12     
==========================================
  Hits           71       71              
- Misses        246      258      +12     
  Partials       10       10
Impacted Files Coverage Δ
request.go 17.29% <0%> (-1.11%) ⬇️
client.go 28.4% <0%> (-1.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ef91ad...2473253. Read the comment docs.

@derekperkins derekperkins merged commit 6f3aa77 into master Nov 7, 2017
@derekperkins derekperkins deleted the deadline-timeout-support branch November 7, 2017 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants