Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abstracted the client.do retry loop to it's own func #32

Merged
merged 1 commit into from
Nov 20, 2017

Conversation

josephbergevin
Copy link
Collaborator

closes #30

@josephbergevin josephbergevin merged commit 45a57de into master Nov 20, 2017
@josephbergevin josephbergevin deleted the client-do-retry-loop-func branch November 20, 2017 21:06
@codecov
Copy link

codecov bot commented Nov 20, 2017

Codecov Report

Merging #32 into master will increase coverage by 0.22%.
The diff coverage is 58.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   38.98%   39.21%   +0.22%     
==========================================
  Files           7        7              
  Lines         454      459       +5     
==========================================
+ Hits          177      180       +3     
- Misses        250      251       +1     
- Partials       27       28       +1
Impacted Files Coverage Δ
client.go 52.99% <58.33%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec52824...e74d001. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client.Do: abstract the retry loop to it's own func
1 participant