-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding param options #49
Conversation
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
==========================================
+ Coverage 42.28% 43.45% +1.17%
==========================================
Files 10 10
Lines 674 688 +14
==========================================
+ Hits 285 299 +14
Misses 349 349
Partials 40 40
Continue to review full report at Codecov.
|
a006608
to
e02714d
Compare
93a2c5f
to
4598f2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Nice work @creedasaurus
f68c820
to
abcd775
Compare
This PR will add functionality to set query parameters on each fetcher request.
Example:
And each subsequent request would be made with the params, properly escaped:
http://example.url.com/path?foo=bar&baz=qux
Also there will be an update to the circleci/reviewdog config.