Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for images inside a step #28

Open
jornncc opened this issue May 20, 2016 · 2 comments
Open

Support for images inside a step #28

jornncc opened this issue May 20, 2016 · 2 comments

Comments

@jornncc
Copy link

jornncc commented May 20, 2016

First of all, great project and work. Really enjoy the many features, especially promised based before & after support.

Have you considered adding support for letting the user specify images inside a step?

What I found out is that I can use markup inside the content, such as this:

tour.steps = [{ target: '#tour-field-list-container', content: '<strong>When creating reports</strong><br>Select fields by checking the box or dragging to the columns list.', }, {

This would create a dialog looking like this:
screen shot 2016-05-20 at 8 15 06 am

Next I was going to try to provide an image tag to see if that would work... but it would be great to be able to provide:
title: <title>,
content: <... the above...>
image:

To build something out of the box...

Thoughts?

@tannerlinsley
Copy link
Collaborator

I would first explore making it so directives compile inside the content.
This would give you the ability to extend the content any way you want.
Just build a new component and let it do it's thing. Thoughts?

On Fri, May 20, 2016 at 10:16 AM jornncc notifications@github.com wrote:

First of all, great project and work. Really enjoy the many features,
especially promised based before & after support.

Have you considered adding support for letting the user specify images
inside a step?

What I found out is that I can use markup inside the content, such as this:

tour.steps = [{
target: '#tour-field-list-container',
content: 'When creating reports
Select fields by
checking the box or dragging to the columns list.',
}, {

This would create a dialog looking like this:
[image: screen shot 2016-05-20 at 8 15 06 am]
https://cloud.githubusercontent.com/assets/15808559/15432422/08010998-1e63-11e6-8a06-8879e0542387.png

Next I was going to try to provide an image tag to see if that would
work... but it would be great to be able to provide:
title: ,
content: <... the above...>
image:

To
build something out of the box...

Thoughts?


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#28

@jornncc
Copy link
Author

jornncc commented May 20, 2016

That would be much better than my suggestion... That would be awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants