Add test for getting ShopifyDomainUtility from DI

nozzlegear · Dec 17, 2023 · 513fecf · 513fecf
1 parent 9cc270f
commit 513fecf
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 20 deletions.
diff --git a/ShopifySharp.Tests/ShopifySharp.Tests.csproj b/ShopifySharp.Tests/ShopifySharp.Tests.csproj
@@ -9,6 +9,8 @@
     <PackageReference Include="fsharp.core" Version="4.7.0" />
     <PackageReference Include="JetBrains.Annotations" Version="2023.3.0" />
     <PackageReference Include="Microsoft.AspNetCore.WebUtilities" Version="2.2.0" />
+    <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="8.0.0" />
+    <PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.0" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.9.0" />
     <PackageReference Include="NSubstitute" Version="5.1.0" />
     <PackageReference Include="xunit" Version="2.4.1" />

diff --git a/ShopifySharp.Tests/TestClasses/TestException.cs b/ShopifySharp.Tests/TestClasses/TestException.cs
@@ -0,0 +1,6 @@
+#nullable enable
+using System;
+
+namespace ShopifySharp.Tests.TestClasses;
+
+public class TestException : Exception;
diff --git a/ShopifySharp.Tests/Utilities/ShopifyOauthUtilityTests.cs b/ShopifySharp.Tests/Utilities/ShopifyOauthUtilityTests.cs
@@ -3,8 +3,11 @@
 using System.Linq;
 using FluentAssertions;
 using JetBrains.Annotations;
+using Microsoft.Extensions.DependencyInjection;
 using NSubstitute;
+using NSubstitute.ExceptionExtensions;
 using ShopifySharp.Enums;
+using ShopifySharp.Tests.TestClasses;
 using ShopifySharp.Utilities;
 using Xunit;
 
@@ -18,14 +21,7 @@ public class ShopifyOauthUtilityTests
     private const string RedirectUrl = "https://example.com/app";
     private const string ClientId = "some-client-id";
 
-    private IShopifyDomainUtility _shopifyDomainUtility;
-    private IShopifyOauthUtility _utility;
-
-    public ShopifyOauthUtilityTests()
-    {
-        _shopifyDomainUtility = Substitute.For<IShopifyDomainUtility>();
-        _utility = new ShopifyOauthUtility(_shopifyDomainUtility);
-    }
+    private ShopifyOauthUtility? _utility;
 
     [Theory]
     [InlineData(null, null)]
@@ -35,12 +31,9 @@ public ShopifyOauthUtilityTests()
     public void BuildAuthorizationUrl_WhenGivenStringScopes_ReturnsTheUrl(string? state, string[]? grants)
     {
         // Setup
+        _utility = new ShopifyOauthUtility();
         var scopes = new[] { "some-permission-1", "some-permission-2" };
 
-        // Mock
-        _shopifyDomainUtility.BuildShopDomainUri(ShopDomain)
-            .Returns(new Uri(Uri.UriSchemeHttps + Uri.SchemeDelimiter + ShopDomain, UriKind.Absolute));
-
         // Act
         var result = _utility.BuildAuthorizationUrl(scopes, ShopDomain, ClientId, RedirectUrl, state, grants);
 
@@ -73,13 +66,10 @@ public void BuildAuthorizationUrl_WhenGivenStringScopes_ReturnsTheUrl(string? st
     public void Builds_Authorization_Urls_With_Enums(string? state, string[]? grants)
     {
         // Setup
+        _utility = new ShopifyOauthUtility();
         string[] expectedEnumStrings = ["read_customers", "write_customers"];
         AuthorizationScope[] scopes = [ AuthorizationScope.ReadCustomers, AuthorizationScope.WriteCustomers ];
 
-        // Mock
-        _shopifyDomainUtility.BuildShopDomainUri(ShopDomain)
-            .Returns(new Uri(Uri.UriSchemeHttps + Uri.SchemeDelimiter + ShopDomain, UriKind.Absolute));
-
         // Act
         var result = _utility.BuildAuthorizationUrl(scopes, ShopDomain, ClientId, RedirectUrl, state, grants);
 
@@ -113,12 +103,9 @@ public void Builds_Authorization_Urls_With_Enums(string? state, string[]? grants
     public void BuildAuthorizationUrl_WhenGivenAuthorizationUrlOptions_ReturnsTheUrl(string? state, string[]? grants)
     {
         // Setup
+        _utility = new ShopifyOauthUtility();
         var scopes = new[] { "some-permission-1", "some-permission-2" };
 
-        // Mock
-        _shopifyDomainUtility.BuildShopDomainUri(ShopDomain)
-            .Returns(new Uri(Uri.UriSchemeHttps + Uri.SchemeDelimiter + ShopDomain, UriKind.Absolute));
-
         // Act
         var result = _utility.BuildAuthorizationUrl(new AuthorizationUrlOptions
         {
@@ -151,4 +138,25 @@ public void BuildAuthorizationUrl_WhenGivenAuthorizationUrlOptions_ReturnsTheUrl
             result.Query.Should().NotContain("grant_options[]=");
     }
     #endif
+
+    [Fact]
+    public void ShopifyOauthUtility_ShouldUseDomainUtilityFromDependencyInjection()
+    {
+        // Setup
+        IServiceCollection container = new ServiceCollection();
+        var domainUtility = Substitute.For<IShopifyDomainUtility>();
+        container.AddSingleton(domainUtility);
+        container.AddSingleton<ShopifyOauthUtility>();
+
+        // Mock
+        domainUtility.BuildShopDomainUri(ShopDomain)
+            .Throws<TestException>();
+
+        // Act
+        _utility = container.BuildServiceProvider().GetService<ShopifyOauthUtility>()!;
+        var act = () => _utility.BuildAuthorizationUrl([ "some-scope" ], ShopDomain, ClientId, RedirectUrl, "some-state", [ "some-grant" ]);
+
+        // Assert
+        act.Should().Throw<TestException>();
+    }
 }