Why AuthorizationResult.cs has an internal constructor?

[evaldas-raisutis]

This makes mocking unnecessarily difficult. Is it a problem for it to have a public constructor? Or a an constructor which takes parameters?

[nozzlegear]

Good catch! I'm not sure why it's an internal constructor, I think we can easily make it public or at least protected without breaking anything.

…

-- Josh Harms

On Wed, Aug 19, 2020, at 05:49, Evaldas wrote: This makes mocking unnecessarily difficult. Is it a problem for it to have a public constructor? Or a an constructor which takes parameters? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#564>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AASOE7D4CEKF4AWOSYZDNULSBOU3PANCNFSM4QEZTXTQ>.

[nozzlegear]

The constructor was made public in ShopifySharp v5.5.0 on nuget 👍