added support for multipass url generator #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @knopa! I don't think I'm familiar with this feature, can you explain what this is for, and add a link to some documentation? |
|
It's from list unimplemented functionality |
|
It's needed when you need to allow auto-create customers from your existing project not Shopify one. So they can use exist credentials to signin into shopify too |
nozzlegear
requested changes
Aug 5, 2022
|
Hey, I have updated as your asked. |
nozzlegear
approved these changes
Aug 8, 2022
nozzlegear
added
release pending
|
Released in 5.18.0 on nuget! Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure how better to do the test. Technically best option is to find the user in Shopify customers by multipass identifier to assert it.