Changed InventoryLevel.Available from int to long #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ged, it is very useful to be able to see the Request-Id for Shopify support to investigate.
clement911
changed the title
|
Thanks for the PR! I'm not sure I'm comfortable with altering the exception message right now. It's probably a bad practice, but it's likely that some people are checking the message value when catching exceptions, as I used to recommend they do that for rate exceptions. I think it should still be possible to access that request ID if you try to cast a generic exception to a ShopifyException? |
… are logged, it is very useful to be able to see the Request-Id for Shopify support to investigate." This reverts commit aec2d2a.
clement911
changed the title
|
Fair enough. |
|
Thanks! Published in 5.2.0 |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across in production an inventory_level with a available quantity lower than int.MinValue