Add missing fields to Shop, Customer and Order, and fix tests for shop in Norway

[Zikoat]

This PR closes:

• Missing Shop property Address2 #653
• Missing Order Property - CheckoutToken #671
• Customer entity missing accepts_marketing_updated_at #574
• Any plans to add support for currency_exchange_adjustment? #521

[Zikoat]

Hiii @nozzlegear, could you take a look at this and see if it can be merged? Having the order's "current" fields would be a lot of help to our app as it would be much easier to calculate the total amount and total outstanding amount on the order.

If you have some questions about the things done in the tests, they were needed to run the tests for our shop which is in Norway.

[nozzlegear]

Sure! I'll try to get this reviewed, merged and published some time today or tomorrow at the latest.

…

-- Josh Harms

On Wed, Oct 6, 2021, at 11:34, Sigurd Schoeler wrote: This PR closes: * #653 <#653> * #671 <#671> * #574 <#574> * #521 <#521> You can view, comment on, or merge this pull request online at: #675 Commit Summary * Add missing fields to Order and Customer <19bc735> * Fix tests that fail when the shops Currency is NOK and Country is Norway <e42f704> * Add missing fields to Shop <7d46fd8> File Changes * *M* ShopifySharp.Tests/Location_Tests.cs <https://github.com/nozzlegear/ShopifySharp/pull/675/files#diff-425b05bad7cd8225c4a653fb0c33594bf0746237637521b970f6d96b86346d8d> (2) * *M* ShopifySharp.Tests/Product_Tests.cs <https://github.com/nozzlegear/ShopifySharp/pull/675/files#diff-4ca7130de9aad4b9d0ac2270e8b3a566518707dd1fc88afcceb2d04bed471725> (9) * *M* ShopifySharp.Tests/Transaction_Tests.cs <https://github.com/nozzlegear/ShopifySharp/pull/675/files#diff-7a64f93ce69d8ea51785415ff28613032f55c0ae60ce323ca99c5e280938ebfd> (16) * *M* ShopifySharp/Entities/Customer.cs <https://github.com/nozzlegear/ShopifySharp/pull/675/files#diff-3e4dd6cb07e3d3bbfc78f712e61b351f71ad1741e9d90f1cbee48306d7e74200> (14) * *M* ShopifySharp/Entities/Order.cs <https://github.com/nozzlegear/ShopifySharp/pull/675/files#diff-acebf3859ab8aa41b097ae06ba378274e6d74e98769f859b5d266fbc92debf7c> (69) * *M* ShopifySharp/Entities/Shop.cs <https://github.com/nozzlegear/ShopifySharp/pull/675/files#diff-358c982315be2368307b0b5040c2910d670f0a8a427b0fe1f84c387c997e9d0c> (64) Patch Links: * https://github.com/nozzlegear/ShopifySharp/pull/675.patch * https://github.com/nozzlegear/ShopifySharp/pull/675.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#675>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AASOE7EMPJZDPIOCYTEEZF3UFR3ABANCNFSM5FPCZHFA>.

[nozzlegear]

Alrighty, I've reviewed your PR and most of it looks good to me! I just need to request a couple changes to the new properties you've added:

1. DateTime should be changed to DateTimeOffset?.
2. bool should be changed to bool?.

In general I try to ensure that all fields are clearly marked as nullable where possible, as we've run into many issues in the past where an unexpected null value breaks deserialization.

[Zikoat]

@nozzlegear Could you review this again? I also changed CheckoutToken to String.

[Zikoat]

@nozzlegear Could you take a look at this and see if you could get it published?

[nozzlegear]

Sure thing, sorry! I've been super busy and let this get away from me. I'll review it within the next few days.

…

-- Josh Harms

On Thu, Nov 11, 2021, at 01:55, Sigurd Schoeler wrote: @nozzlegear <https://github.com/nozzlegear> Could you take a look at this and see if you could get it published? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#675 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AASOE7CQSYCXXL7JFCO7TATULNZHZANCNFSM5FPCZHFA>.

[nozzlegear]

Published in v5.14.0 on nuget. Thank you very much for the pull request!