Added ability to override the API version used when instantiating a GraphService #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any idea when this can be approved. I have a similar use case where i need to set the version to the latest in order to access some nodes in the graph service that are only available in the latest version. |
|
This has been released in 5.16.0 on nuget! Sorry about the wait! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShopifySharp is pinned to an API version, which makes sense when using the REST API because the requets and responses objects are defined in the library itself.
However, for GraphService, it makes sense to be able to override the desired API version since the response is dictated by the shape of the request.
For example, right now I'd like to create a grapqhQL request with the latest stable version but I can't because ShopifySharp is pinned to an earlier version. (I know that I can override the GraphService and override the api version but I think that being able to override it in the constructor makes it a lot easier).