Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service interfaces #891

Merged
merged 12 commits into from
Jun 27, 2023
Merged

Service interfaces #891

merged 12 commits into from
Jun 27, 2023

Conversation

nozzlegear
Copy link
Owner

@nozzlegear nozzlegear commented Jun 25, 2023

This pull request will add interfaces for all ShopifySharp service classes.

TODO:

  • Update contribution docs (all new services should have an interface; all new methods should be added to existing interface).
  • Determine how to handle the HttpClient/HttpClientFactory stuff on the ShopifyService/IShopifyService class and interface. I'm okay with leaving this off for now and implementing in the next pull request, but want to start considering it.
    • Should the instance-specific service.SetHttpClient be replaced with a service.SetHttpClientFactory instead? See my todo here.
    • Or should a constructor overload be added that accepts an IHttpClientFactory? This could make the services more DI friendly (I want to implement a ShopifyServiceCredentials class or something like it so we don't have to pass strings to the services).

@nozzlegear nozzlegear marked this pull request as draft June 25, 2023 05:31
@nozzlegear nozzlegear marked this pull request as ready for review June 25, 2023 06:39
@nozzlegear nozzlegear merged commit 940350e into master Jun 27, 2023
@nozzlegear nozzlegear deleted the service-interfaces branch December 11, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant