Jekyll #851
Merged
Jekyll #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robinlovelace
requested changes
Sep 23, 2020
There was a problem hiding this comment.
This PR tackles two issues simultaneously: the need to use Jekyll (I can see the benefits of static site generators but not sure what the benefits would be vs costs of additional complexity for this fairly simple use case and how it would compare with other options such as Hugo) and the need to update the website. I suggest splitting this PR, that adds over 1000 lines and removes 113, into two 'atomic' PRs unless there is a good reason for bundling the two things together. Thinking: that will make it easier to review, with the update to location of links to the accessibility statement being the priority.
3 tasks
Robinlovelace
approved these changes
Sep 23, 2020
This was referenced Sep 23, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #848
Moving to using a Jekyll. I can incoporate it into the github push workflow but for now I've just done it manually with:
cd jekyll-static jekyll s -d ../regions_www@Robinlovelace any thoughts?