-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use NpgsqlDataSource in all tests #4882
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for doing all the legwork!
See some comments below, nothing critical that can't be fixed later in a separate PR.
One slight concern is that we now have much less actual test coverage for the non-datasource mode, so things may end up regressing without us knowing. Something to keep in mind.
b39319a
to
dd67aa5
Compare
@vonzshik pushed 2 commits to this PR - take a look. |
Closes #4572