Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Timeformat: Display seconds on long duration (>3600s) #16

Closed
wants to merge 1 commit into from
Closed

Changed Timeformat: Display seconds on long duration (>3600s) #16

wants to merge 1 commit into from

Conversation

rekinyz
Copy link

@rekinyz rekinyz commented Dec 10, 2017

formatTime(3891) = 1h4m51s

@AndiDittrich AndiDittrich changed the title Bugfix: longer duration can now be displayed correctly Changed Timeformat: Display seconds on long duration (>3600s) Dec 10, 2017
@AndiDittrich
Copy link
Member

hi rekinyz,

i'm not shure if we should change this...it was a "by design" decision to hide seconds on long duration (not even needed) - why you want to change it ?

btw. i've changed the issue name

best regards, Andi

@rekinyz
Copy link
Author

rekinyz commented Dec 10, 2017

Hi Andi,

I am using this lib for displaying the export progress. Some of my exports will take hours. But with the old function, formatTime(3691) = 1h1.5166666666666666m. I think if you just don't want to display the seconds, you still need to round the minutes.

best regards,
rekinyz

@AndiDittrich
Copy link
Member

now i understand your issue :)

it is caused by a "wrong" call of the Bar.prototype.formatTime function. the second parameter roundTo was not set for elapsedTime calculation. i will fix it now

AndiDittrich added a commit that referenced this pull request Dec 10, 2017
…d raw float values within formatted time strings #16
@AndiDittrich
Copy link
Member

should be fixed, please try it

@rekinyz
Copy link
Author

rekinyz commented Dec 11, 2017

danke, es hat funktioniert 👍

@AndiDittrich
Copy link
Member

alles klar, dann schließe ich den pull-request und werde die neue version vorraussichtlich heute freigeben

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants